[HOLD for payment 2023-05-25] [$1000] Dev: console error when emoji suggestions list open

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1.go to any chat
2. type text and use semi colon syntax to show emoji suggestions(like 😄)
Expected Result: should not show any console error
Actual Result: shows console error(Invalid prop preferredSkinToneIndex of type string supplied to EmojiSuggestions, expected number. )

Expected Result:

should not show any console error

Actual Result:

shows console error(Invalid prop preferredSkinToneIndex of type string supplied to EmojiSuggestions, expected number. )

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: dev
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Simulator.Screen.Recording.-.iPhone.13.-.2023-05-05.at.19.10.18.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683294088031149

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c039b897065c50fb
• Upwork Job ID: 1656323428664475648
• Last Price Increase: 2023-05-10

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that when we try to type any text after : for the emoji suggestion list, a console error is shown on all platforms, highlighting a prop type mismatch error.

What is the root cause of that problem?

In the EmojiSuggestions component, we have set the prop type to be equal to PropTypes.number. When the user has not selected any skin tone however, the preferredSkinToneIndex passed to the component is "default", which is not a number. Thus, we get the error.

App/src/components/EmojiSuggestions.js

Line 46 in d120f6a

preferredSkinToneIndex: PropTypes.number.isRequired,

What changes do you think we should make in order to solve the problem?

We should modify the prop type for preferredSkinToneIndex to use the PropTypes.oneOfType and pass the values such that it can be either number or string.

What alternative solutions did you explore? (Optional)

None

[slafortune]

Still producible on Dev https://expensify.slack.com/archives/C049HHMV9SM/p1683294088031149 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c039b897065c50fb

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.