[HOLD for payment 2023-06-02] [$1000] Web - LHN - The page of the new group does not open if you press "Ctr+ENTER"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Log in HT account
3. In a account with a lot of active conversations, click on the green + icon on the home screen.
4. Click New Group. The New Group Page should open.
5. Without selecting any results, press Ctr+Enter. Nothing should happen.
6. Select several results.
7. Press Ctr+ENTER, and a group should be opened with your selected results.

Expected Result:

Nothing should happen if users are not selected from the contact list after you press Ctr+Enter, but group should be opened with your selected results if you press Ctr+Enter.

Actual Result:

Selected multiple results from the contact lists but not opened group with selected results if you press Ctr+Enter.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Web / Chrome
• MacOS / Desktop

Version Number: 1.3.10.2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6043790_Recording__564.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0156a1fe3b554ad240
• Upwork Job ID: 1655725621488488448
• Last Price Increase: 2023-05-09

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Keyboard shortcut (CTR+ENTER) does not work when new group chat selector is open

What is the root cause of that problem?

The root cause of this issue is that an incorrect keyCommandEvent is returned here. The returned keyCommandEvent does not take into account the key modified (CMD in this case). This causes the listener for the ENTER shortcut key being executed instead of the CMD+ENTER.

The reason for the incorrect command type being received is because of a bug in our react-native-key-command library.
Precisely, this condition is the culprit. The commands array has the ENTER shortcut occurring before the CMD+ENTER shortcut. While looping over the commands, the ENTER command comes first and is tested against this condition:

(item.input === json.input)
        && matchesModifierFlags(item)
    ) || (
        matchesEnter(item) && matchesModifierFlags(item) ----> For enter shortcut, this returns false
    ) || matchesEscape(item)
        || matchesEnter(item) ----> This returns true
        || matchesUpArrow(item)
        || matchesDownArrow(item)
        || matchesLeftDown(item)
        || matchesRightDown(item)

The above returns the index of ENTER shortcut instead of returning the ENTER+CMD shortcut index.

What changes do you think we should make in order to solve the problem?

We need to do a strict check (with modifier keys) first, followed by a loose check (without modifier key). This needs to be replaced with:

const strictIndex = _.findIndex(commands, item => (
    item.input === json.input && matchesModifierFlags(item) 
    || matchesEnter(item) && matchesModifierFlags(item)
  ));
  if(strictIndex < 0) {
    return _.findIndex(commands, item => (
      item.input === json.input && matchesModifierFlags(item) 
      || matchesEnter(item) && matchesModifierFlags(item)
      || matchesEscape(item)
      || matchesEnter(item)
      || matchesUpArrow(item)
      || matchesDownArrow(item)
      || matchesLeftDown(item)
      || matchesRightDown(item)
    ));
  }
  return strictIndex;

What alternative solutions did you explore? (Optional)

We can also sort the commands here such that the commands with modifiers come before the commands without modifiers.

[melvin-bot]

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Makes sense, adding the External label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0156a1fe3b554ad240

[melvin-bot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.