[HOLD for payment 2023-05-22] Workspace - invitation message defaults even when deleted

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open chrome web
2. Create a new workspace
3. Go to invite members
4. Select a user and in the message field, remove everything and invite an user
5. Go to the user's email and notice that even when the message was already deleted while inviting the user, the default message is still shown on the email

Expected Result:

The default message should not be shown in the email when the message was already deleted while inviting the user

Actual Result:'

The default message is sent in the email even when the message was already deleted and was empty

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.9.16
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-05-03_19.00.24.mp4

Recording.475.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683120050629809

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

The default message is sent in the email even when the message was already deleted and was empty

What is the root cause of that problem?

When Invite button tapped it will call sendInvitation() function as shown below:

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Lines 111 to 115 in c7a8a88

	sendInvitation() {
	Policy.addMembersToWorkspace(this.props.invitedMembersDraft, this.state.welcomeNote || this.getWelcomeNote(), this.props.route.params.policyID);
	Policy.setWorkspaceInviteMembersDraft(this.props.route.params.policyID, []);
	Navigation.navigate(ROUTES.getWorkspaceMembersRoute(this.props.route.params.policyID));
	}

At line 112 we are calling Policy.addMembersToWorkspace() within that, second parameter is this.state.welcomeNote || this.getWelcomeNote() So here when this.state.welcomeNote is empty it will get default welcome note via this.getWelcomeNote() function as shown below:

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Lines 100 to 104 in c7a8a88

	getWelcomeNote() {
	return this.props.translate('workspace.inviteMessage.welcomeNote', {
	workspaceName: this.props.policy.name,
	});
	}

So although user make welcomeNote empty it will grab default welcome note from this.getWelcomeNote() function. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

To solve this we have to remove this.getWelcomeNote() from second parameter condition at line 112. i.e. We have to just pass this.state.welcomeNote as second parameter. So updated code look as shown below:

sendInvitation() { 
   Policy.addMembersToWorkspace(this.props.invitedMembersDraft, this.state.welcomeNote, this.props.route.params.policyID); 
   ...
} 

So this will solve the issue and does not send welcome note when it is empty.

What alternative solutions did you explore? (Optional)

None

[Christinadobrzyn]

Testing this, it's required to send an invitation message:

• if you delete the default message, it will still send the default message.
• If you edit the message and send a custom message it will send that custom message.

Do we want to allow users to send an invitation without any message? Asking for more thoughts about that in the Slack thread.
https://expensify.slack.com/archives/C049HHMV9SM/p1683231084569769?thread_ts=1683120050.629809&cid=C049HHMV9SM

[Christinadobrzyn]

hey @sobitneupane would you be able to see if this is a regression from #14568

[sobitneupane]

No, it is not. In fact, this was the issue which removes the default message from the email if user deletes it and invitation message is empty.

This issue is a regression from #15672.

[Christinadobrzyn]

Asking in PR about regression - #15672

[abdulrahuman5196]

Yes. Seems to be a regression. Will raise a PR to fix it.

But a curious question why wasn't this caught during regression test? Since there was a regression test in the original code test - #14568 (comment)