[HOLD for payment 2023-05-29] [$1000] ‘Message’ input field is not auto-focused even though it is the only input field in the page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on ‘Profile’ avatar
2. Click on ‘Workspaces’ link
3. Open an existing workspace
4. Click on ‘Manage members’ link
5. Click on ‘Invite’ button
6. Enter email address > select user > click on ‘Next’ button

Expected Result:

Message input field should be auto-focused

Actual Result:

Message input field is not auto-focused

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.9-14
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-03.04.42.18.mp4

Recording.470.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683078396397269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0144056c8fb602a0e4
• Upwork Job ID: 1655570989713260544
• Last Price Increase: 2023-05-08

[MelvinBot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

Within workspace invite message page, Message input field is not auto-focused even though it is the only input field in this page.

What is the root cause of that problem?

Message input field is rendered via this code.

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Lines 193 to 205 in c7a8a88

	<TextInput
	inputID="welcomeMessage"
	label={this.props.translate('workspace.inviteMessage.personalMessagePrompt')}
	autoCompleteType="off"
	autoCorrect={false}
	numberOfLines={4}
	textAlignVertical="top"
	multiline
	containerStyles={[styles.workspaceInviteWelcome]}
	defaultValue={this.state.welcomeNote}
	value={this.state.welcomeNote}
	onChangeText={text => this.setState({welcomeNote: text})}
	/>

We can see that text input component is not focused by any way on this page. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

We have to create ref for text input and autofocus it at transition end. i.e. We have to pass onEntryTransitionEnd prop to ScreenWrapper component as shown below. Also there is default text value exist within text input, so we have to put cursor at end of the message via setSelectionRange() as shown below.

<ScreenWrapper
    onEntryTransitionEnd={() => {
        if (!this.welcomeMessageInputRef) {
            return;
        }
        this.welcomeMessageInputRef.focus();
        const length = this.welcomeMessageInputRef.value.length;
        this.welcomeMessageInputRef.setSelectionRange(length, length);
    }}
    ...
>
   ....
  <TextInput
      ref={el => this.welcomeMessageInputRef = el}
      ...
  />
   ...
</ScreenWrapper>

So this will solve the issue as shown in result video.

Note: We can also keep existing text as selected while focus the text input by using this.welcomeMessageInputRef.select() or this.welcomeMessageInputRef.setSelectionRange(0, length) if need.

What alternative solutions did you explore? (Optional)

We can also set autoFoucs and shouldDelayFocus as shown below, but it will not put cursor at the end of the existing message, so not suggested.

<TextInput
    autoFocus
    shouldDelayFocus
    ...
/>

Results

18371-InviteMemberAutoFocus.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0144056c8fb602a0e4

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)