[$1000] DEV: Unnecessary API call on click of sign in button even though the magic code is not filled

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to login page
2. enter email and click on continue
3. enter the wrong magic code
4. remove the code
5. Press sign in button

Expected Result:

should not call API to validate magic code if code is not filled

Actual Result:

unnecessary API call to validate magic code

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Happening in Dev
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-01.at.2.23.34.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682931438573489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa55ab729be6de63
• Upwork Job ID: 1657949973471617024
• Last Price Increase: 2023-05-15

[MelvinBot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jliexpensify]

@kavimuru - I don't have a DEV environment as I am not an Engineer. Would you like me to assign an Engineer?

@mallenexpensify - just tagging you to ask if DEV issues should go directly to the Engineering team instead?

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When magic code is not filled and click sign in button, frontend validation passes and call backend api

What is the root cause of that problem?

validateCode state value is not updated when backspace/delete key is pressed. So validated stale value is remaining and passes this validation:

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Line 171 in ce3b938

if (!ValidationUtils.isValidValidateCode(this.state.validateCode)) {

What changes do you think we should make in order to solve the problem?

On Backspace key press event, on this callback, call props.onChangeText - same code as here when any numeric key is pressed.

[jliexpensify]

Re-assigning for Engineering eyes (as per this comment)

[MelvinBot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

@deetergp, @jliexpensify Eep! 4 days overdue now. Issues have feelings too...

[deetergp]

If this only happens in DEV and it's making a call to the local API, why do we care?