[HOLD for payment 2023-05-23] [$1000] Composer not displayed when changing screen size during comment editing in Expensify

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to Expensify and start a conversation on a small screen size.
2. Send a message and click the "Edit" button to edit the message.
3. Change the screen size from mobile width to web or tablet width.
4. Click "Cancel" to exit the edit mode.

Expected Result:

After canceling the edit, the composer should be displayed.

Actual Result:

The composer is not displayed.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.8.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.435.mp4

Screen.Recording.2023-05-01.at.11.23.48.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @ahmdshrif
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682930338820919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0108128bec6e5358cf
• Upwork Job ID: 1655770448285188096
• Last Price Increase: 2023-05-09

[MelvinBot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmdshrif]

Proposal

Problem Statement

When editing a commentand changing the screen size from mobile width to web or tablet width, the composer is not displayed after canceling the edit. This behavior occurs because the ShoudShowCompersInput state is only updated on small screen widths.

Root Cause

The root cause of this problem is that the composer is not being displayed after canceling the comment edit because the state that controls the display of the composer is only updated on small screen widths.

Proposed Solution

To solve this issue, i propose updating the return condition in the code snippet below:

App/src/libs/toggleReportActionComposeView/index.js

Lines 1 to 9 in 8e06eb0

	import * as Composer from '../actions/Composer';
	export default (shouldShowComposeInput, isSmallScreenWidth = true) => {
	if (!isSmallScreenWidth) {
	return;
	}
	Composer.setShouldShowComposeInput(shouldShowComposeInput);
	};

i suggest updating the code to:

if (!isSmallScreenWidth && !shouldShowComposeInput) {
   return;
}

This updated return condition will prevent the composer from being hidden on mid-size and large screens while ensuring that it is still displayed on small screens.

Alternative Solutions Explored

we can ignore shouldShowComposeInput if we in mid or large screen and display composer anyway like that

App/src/pages/home/report/ReportFooter.js

Line 88 in 8e06eb0

{(!hideComposer && this.props.shouldShowComposeInput) && (

to :

                {(!hideComposer && (this.props.shouldShowComposeInput || !this.props.isSmallScreenWidth)) && (

[MelvinBot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johncschuster]

I've reproduced this on Safari using the reproduction steps above