[HOLD for payment 2023-06-15] [$1000] Deleted message gets highlighted when we send a message, delete the message, visit any other chat and revisit the chat in offline mode

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Switch to offline mode
4. Delete any message (currently it is not highlighted)
5. Switch to other report and revisit the deleted message report to see that message is highlighted now
6. Switch off offline mode
7. Again visit the chat to see that deleted message is now gone
8. Switch back the offline mode
9. Revisit the chat and deleted message is back and it is still highlighted

Expected Result:

App should not highlight deleted message on revisiting chat in offline mode nor have the deleted message reappear after reconnecting online then offline

Actual Result:

App highlights deleted message on revisiting chat in offline mode and highlight remains intact. App shows deleted message in offline mode even after going back online then offline again.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

delete.in.offline.mode.highlights.the.message.mp4

Recording.412.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682681346161399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013afb44ff7c31e750
• Upwork Job ID: 1654091952987746304
• Last Price Increase: 2023-06-01

[MelvinBot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

reviewing today!

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The deleted message while offline has a hover effect after switching back from another chat.

What is the root cause of that problem?

The hover effect will show if:

1. is hovered
2. is a whisper
3. a context menu active
4. is a draft message
   

   App/src/pages/home/report/ReportActionItem.js

   Lines 282 to 286 in ce3b938

   	style={StyleUtils.getReportActionItemStyle(
   	hovered
   	|| isWhisper
   	|| this.state.isContextMenuActive
   	|| this.props.draftMessage,

and the condition that it meets is the third one. Why?

When we delete a chat, it will show a delete modal by calling showDeleteModal of PopoverReportActionContextMenu passing the selected report action id and the report id.

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Lines 287 to 296 in ce3b938

	showDeleteModal(reportID, reportAction, shouldSetModalVisibility = true, onConfirm = () => {}, onCancel = () => {}) {
	this.onCancelDeleteModal = onCancel;
	this.onComfirmDeleteModal = onConfirm;
	this.setState({
	reportID,
	reportAction,
	shouldSetModalVisibilityForDeleteConfirmation: shouldSetModalVisibility,
	isDeleteCommentConfirmModalVisible: true,
	});
	}

When we confirm the deletion, we

1. delete the message
2. hide the modal
   

   App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

   Lines 261 to 265 in ce3b938

   	confirmDeleteAndHideModal() {
   	this.callbackWhenDeleteModalHide = () => this.onComfirmDeleteModal = this.runAndResetCallback(this.onComfirmDeleteModal);
   	Report.deleteReportComment(this.state.reportID, this.state.reportAction);
   	this.setState({isDeleteCommentConfirmModalVisible: false});
   	}

One thing is missing is to reset the report action id and report id. So, when we reopen the chat, it will remount the component and check, is this chat message has an active context menu?

App/src/pages/home/report/ReportActionItem.js

Lines 99 to 101 in ce3b938

	this.state = {
	isContextMenuActive: ReportActionContextMenu.isActiveReportAction(props.action.reportActionID),
	};

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Lines 110 to 112 in ce3b938

	isActiveReportAction(actionID) {
	return Boolean(actionID) && this.state.reportAction.reportActionID === actionID;
	}

Because we didn't clear the report action id, it will say, yes, a context menu is active for this chat message.

This issue however doesn't happen when we simply cancel the deletion because when we cancel it, we will call hideDeleteModal that will reset the report action id and along with other state.

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Lines 267 to 277 in ce3b938

	hideDeleteModal() {
	this.callbackWhenDeleteModalHide = () => this.onCancelDeleteModal = this.runAndResetCallback(this.onCancelDeleteModal);
	this.setState({
	reportID: '0',
	reportAction: {},
	isDeleteCommentConfirmModalVisible: false,
	shouldSetModalVisibilityForDeleteConfirmation: true,
	isArchivedRoom: false,
	isChronosReport: false,
	});
	}

UPDATE: It's no longer true because we remove the reportActions reset here

What changes do you think we should make in order to solve the problem?

Reset both report action and report id in onModalHide callback of ConfirmModal

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Line 332 in b6eb637

onModalHide={this.callbackWhenDeleteModalHide}

onModalHide={() => {
    this.setState({reportID: '0', reportAction: {});
    this.callbackWhenDeleteModalHide()
}}

[dylanexpensify]

Didn't get to this today due to focusing on ECUK and CPM tasks! Will review tomorrow!

[dylanexpensify]

Posted about this to get clarification on expected behavior. Will update this once we come to a conclusion.

[dylanexpensify]

After discussing we confirmed that this is an expected behavior! @dhanashree-sawant here's where you can find more info!

[dhanashree-sawant]

Hi @dylanexpensify, In the document, we have mentioned that it should be greyed out but in the issue, the deleted message gets highlighted not greyed out. It gets greyed out when we delete but when we revisit the chat, it gets highlighted.

[dylanexpensify]

I believe that makes sense it's still highlighted while in offline mode, since technically, the delete action hasn't registered 100% yet. I think this would be a bug if we got back online, and the deleted comment did finish deletion, but then still highlighted after switching back. Mind confirming for me it doesn't do that?