[HOLD for payment 2023-05-16] [$1000] Adding spaces after workspace names causes a temporary loss of name position

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Workspaces > General settings
2. Enter spaces after workspace name

Expected Result:

Adding spaces after workspace names, the name must remain in the same position

Actual Result:

Adding spaces after workspace names causes a temporary loss of name position

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-04-25.03-18-49.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682416466951609

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b8861e605da12033
• Upwork Job ID: 1651227961524355072
• Last Price Increase: 2023-04-26

[MelvinBot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

When add some spaces during workspace name save, it will show workspace name at different position for few moment.

What is the root cause of that problem?

When we add space within workspace name and Save, It will call submit() function here.

App/src/pages/workspace/WorkspaceSettingsPage.js

Lines 62 to 70 in f3fae40

	submit(values) {
	if (this.props.policy.isPolicyUpdating) {
	return;
	}
	const outputCurrency = values.currency;
	Policy.updateGeneralSettings(this.props.policy.id, values.name, outputCurrency);
	Keyboard.dismiss();
	Navigation.navigate(ROUTES.getWorkspaceInitialRoute(this.props.policy.id));
	}

We can see at line 67 it is calling Policy.updateGeneralSettings() with values.name without trim.

So Policy.updateGeneralSettings() api will set workspace name within optimisticData as shown in line 416

App/src/libs/actions/Policy.js

Line 416 in f3fae40

name,

So during Save it will show optimistic data that consist workspace name with space, and once api call finish it shows data from onyx that consist workspace name trimmed. So this is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

We have to trim workspace name within submit() function while calling Policy.updateGeneralSettings() as shown below. It will solve the issue as shown in Results video.

submit(values) {
    ...
    // Policy.updateGeneralSettings(this.props.policy.id, values.name, outputCurrency);  // *** Old Code
    Policy.updateGeneralSettings(this.props.policy.id, values.name.trim(), outputCurrency);  // *** Updated Code
   ...
}

What alternative solutions did you explore? (Optional)

We can trim workspace name while showing within ui, but this is not good idea. It will not solve the root cause of the issue. Also while we display info within ui we do not trim anywhere in the app. So this is not a good solution. So I will not suggest it.

Results

18006.-Workspace.mov

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01b8861e605da12033

[MelvinBot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)