[HOLD for payment 2023-05-16] [$1000] wrong keyboard type on add New contact method

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go Settings > Profile > Contact methods
2. click on New contact method button
3. click on Email/Phone number input field

Expected:

keyboard type should be email address (same as login screen)which contains @ symbol

Actual:

default keyboard appears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682411521345929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b8315d0c90ac132
• Upwork Job ID: 1651615643428438016
• Last Price Increase: 2023-04-27

[MelvinBot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

keyboard type is default instead of email address while adding a New contact method

What is the root cause of that problem?

keyboard type is not added for the New contact method input field

What changes do you think we should make in order to solve the problem?

add keyboardType={CONST.KEYBOARD_TYPE.EMAIL_ADDRESS} to below TextInput field and add import CONST from '../../../../CONST';

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Lines 106 to 113 in f3fae40

	<TextInput
	label={`${props.translate('common.email')}/${props.translate('common.phoneNumber')}`}
	ref={loginInputRef}
	value={login}
	onChangeText={handleLoginChange}
	autoCapitalize="none"
	returnKeyType={Permissions.canUsePasswordlessLogins(props.betas) ? 'done' : 'next'}
	/>

[sophiepintoraetz]

Able to reproduce!

[MelvinBot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~016b8315d0c90ac132

[MelvinBot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.