[HOLD for payment 2023-05-16] [$1000] Web does not show not show notifications for not active window.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to web chrome and login with account A.
2. Go to any chat with account B.
3. Open any other app on the device so that browser windows gets unfocused.
4. Send message from another device with logined with account B to Account A.
5. Notice that no notification is received.

Expected Result:

If we try the same steps on Desktop, we show the notifications but it does not happen on web. We should either hide notifications from both Web and desktop or show on both.

Actual Result:

Desktop shows the notification but web does not which is inconsistent.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
web
https://user-images.githubusercontent.com/43996225/231000203-1d3c585b-545d-43ee-8851-1ca9d33abaab.mp4

desktop
https://user-images.githubusercontent.com/43996225/231000209-79e9537d-0d3f-41ba-9a41-99bba3e26e90.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681142429319059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b13c230ee4bc52cb
• Upwork Job ID: 1646713133914791936
• Last Price Increase: 2023-04-14

[MelvinBot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[francoisl]

@arosiclair @neil-marcellini any ideas if this is related to #15858 ? I was able to reproduce the issue - if you leave your browser on the NewDot tab and switch focus to another app, we don't show a notification if you receive a new message from another device.
If the NewDot tab is not active in your browser before switching to another app though, we do show the notification.

[francoisl]

Actually I can reproduce on production as well, so it might not be this 🤔

[parasharrajat]

@francoisl Actually, this issue was found on #15858 #15858 (comment)

[francoisl]

Oh I see, thanks for clarifying.

[arosiclair]

Yeah the line of code that's controlling this is here. Visibility.isVisible() has different implementations for each platform here. So we'd have to update that in some way to fix this issue. Looks like you have to minimize or switch tabs to get isVisible() to be false on web currently.