[Hold] Update DeleteMembersFromWorkspace to work with optimistically creates chats offline

[bondydaa]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Hold for #16764 has been merged to be merged

Action Performed:

Break down in numbered steps

1. Go offline
2. Add new member to workspace, see optimistic report added to LHN
3. Remove user from workspace, optimistic report stays in LHN
4. Go online
5. Optimistic report in LHN becomes "real chat", if you open that chat it then disappears from LHN and you see it's archived.

Expected Result:

When you remove a user from a workspace their optimistic expense policy chat should have the "strike through" UI to indicate the pending removal action and once the user goes online the chat should be archived.

Though this bring a question to mind: should the user never actually be added and subsequently archived? I'm am not sure about how this is expected to work with offline first.

Actual Result:

The chat remains in the LHN and appears as a "normal" chat until the user opens the chat, at that point the chat is loaded and shown as Archived and removed from the LHN.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Not yet, will only show after is merged #16764
Reproducible in production?: Not yet, will only show after is merged #16764
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856 n/a
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL: n/a
Issue reported by: @bondydaa
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017ce054ad9e1bebb6
• Upwork Job ID: 1654578579504644096
• Last Price Increase: 2023-05-05

[MelvinBot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bondydaa]

@garrettmknight this is on hold until #16764 is merged, I just wanted to get it opened so we can add any other bugs related to this API command so we can keep the scope of #16764 focused on just AddMembersToWorkspace API command.

[garrettmknight]

Sounds good, will check in later this week

[garrettmknight]

PR is still open, continuing to hold

[garrettmknight]

PR is still open, moving to weekly.