[HOLD for payment 2023-04-20] [$1000] Inconsistency hint text for zipcode on home address page vs the connect bank account page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome
2. Go to settings
3. Go to Personal Information and search for any location
4. Notice that below the zipcode field, it displays the text as 'Format'
5. Now go to any workspace. Go to connect bank account page
6. Fill in the details and in the step 2 , notice that below the zipcode field, it mentions as 'e.g'. Thus, for the same field in two different areas on the application, different texts are displayed.

Expected Result:

To maintain consistency between the same zipcode field in home address vs the connect bank account page, it should either display 'format' or it should display 'e.g' in both pages.

Actual Result:

In the home address page, the text has been displayed as format, whereas in the connect bank account page, the text has been displayed as 'e.g' for the same zipcode field.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.94-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

format-2023-04-04_10.24.11.mp4

Recording.130.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680583640960019

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018fb5c289df121167
• Upwork Job ID: 1643295291269828608
• Last Price Increase: 2023-04-04

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

Let's use the e.g. format in both places. Ideally we can just use the same constant for the subtext in both places.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~018fb5c289df121167

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

the zip / postal code hint text is inconsistent across Home and Bank account page

What is the root cause of that problem?

The hint is being applied by adding Format: instead of e.g.

What changes do you think we should make in order to solve the problem?

We should replace Format: here to e.g. which makes the hint consistent across the required pages.

App/src/languages/en.js

Line 131 in aa1e2ed

format: ({zipSampleFormat}) => (zipSampleFormat ? `Format: ${zipSampleFormat}` : ''),

What alternative solutions did you explore? (Optional)