[$250] Timezone - The automatic time zone is selected with the incorrect spelling "Kiev"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #16777

Action Performed:

Preconditional: user should be located in Europe/Ukraine

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings -> Profile -> Timezone
4. Disable the option "Automatically determine your location"
5. Click on the timezone selector below
6. In the search input, search for Kyiv
7. Enable the option "Automatically determine your location"

Expected Result:

The time zone is set with the correct spelling - Europa/Kyiv

Fix this upstream in moment repo

Actual Result:

A time zone with incorrect spelling is being set - Europe/Kiev

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.94.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6004847_Recording__4089.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010a8578e77393b86c
• Upwork Job ID: 1643659043634610176
• Last Price Increase: 2023-04-13

[MelvinBot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[strepanier03]

Working through this now.

[strepanier03]

Saving - https://en.wikipedia.org › wiki › KyivNotKiev

[strepanier03]

I cannot test this so I raised in Slack here to get a buddy check test going.

If no one responds by the time I get back to GHs tomorrow I'll just move forward.

[thienlnam]

I imagine this is coming from the moment-timezone API, I don't think we're modifying it on our end

[Prince-Mendiratta]

@strepanier03 It isn't necessary to be located in Ukraine to test this issue, you can test the automatic timezone resolution by setting your device timezone to Europe/Kyiv.

As for the RCA and solution to this issue, it is as pointed out by @thienlnam, it relies on moment-timezone API. It is because of 2 issues:

1. We are using an outdated version of moment-timezone, which makes use of an outdated version of the IANA database (2020), which is the underlying database for moment-timezone.
2. Even on the latest database version, it is possible for the timezone to be set to kiev as the database includes old data as well for backward compatibility. I asked for more info in this github issue. As it turns out, there are more deprecated names present in the database which we will have to manually filter out from the list, if required. See https://www.github.com/moment/moment-timezone/issues/227 for an old discussion about this in Moment Timezone, and https://www.github.com/tc39/proposal-temporal/issues/2509 for a (much longer) discussion for TC39's Temporal proposal

If this can be made external, I can send in a proposal for this issue.

[strepanier03]

Thank you for the hint about testing @Prince-Mendiratta and for the comments. And thanks for @thienlnam as well.

I'm going to send this external and we'll take it from there.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010a8578e77393b86c