[HOLD for payment 2023-02-24] Sign in - No button small language picker on the sign in page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

issue found when executing PR #14851

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Go to Settings -> Preferences -> Language
4. Change the language
5. Verify it works as expected
6. Log out
7. On the sign in page, change the language from the small language picker

Expected Result:

User can change language from the small language picker on the sign in page.

Actual Result:

No button small language picker on the sign in page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.68.0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5930664_Recording__290.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016436adaef72de55c
• Upwork Job ID: 1625881288903913472
• Last Price Increase: 2023-02-15

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

cc @cristipaval

[cristipaval]

Thanks @mountiny !
yeah, this might be related to my PR. I'll assign it to me for a quick look.

[MelvinBot]

@michaelhaxhiu, @cristipaval Eep! 4 days overdue now. Issues have feelings too...

[cristipaval]

Hmm.. I can't reproduce this one on dev.

[cristipaval]

I think the issue happens due to these lines.
i18n is behind a beta flag, but on SignIn page we have no beta flag fetched from the backend, because betas are bound to the account. I wonder if we can always render the LocalePicker component, with no check for i18n beta flag, since this has been already for ages in production.