Skip to content

[$1000] Remove 'require cycles' developer warning message  #14816

Description

@Julesssss

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


As pointed out here, a new developer warning message was introduced by this PR. It is not a regression, but should be fixed. I attempted to resolve this myself here, but it appeared to break notifications 😕

We need to correctly import the Push Notification library, making sure that notifications work in all cases:

  • App open
  • App backgrounded
  • App backgrounded with sign out and sign in with different account
  • App killed

Action Performed:

  1. As a developer, launch the app to an iOS or Android device/simulator
  2. Notice the following warning

Expected Result:

The warning should not show

Actual Result:

The warning shows

Workaround:

This is a developer-only issue, and it isn't a blocker

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • iOS / native

Issue reported by: @dhairyasenjaliya

Simulator Screen Shot - iPhone 14 Pro Max - 2023-01-31 at 23 00 57
Simulator Screen Shot - iPhone 14 Pro Max - 2023-01-31 at 23 00 45

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019a3456a58e369fbd
  • Upwork Job ID: 1624093100668227584
  • Last Price Increase: 2023-02-10

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.ReviewingHas a PR in review

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions