Problem
As noted in this GH: #12268 , we were allowing users to submit workspace names with html tags. However, for most of these string form fields, we strip the html/xml tags in our WAF input rules. So even though we allow users to submit strings with tags in them, we filter them out without letting the user know and try to save the stripped-string on the php side.
cc @flodnv
Two examples I've found:
I'm sure there are a lot of others. Lets find them and do the following
Action Preformed
- Go to Settings -> Profile
- Add a string with html tags like
<b> </b>
- Verify that its stripped without any warning
https://recordit.co/TTr47jOQSR
View all open jobs on GitHub
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ac69cf8741f82a09
- Upwork Job ID: 1618748539495436288
- Last Price Increase: 2023-01-26
List of instances
-
LegalNamePage.js -- legalFirstName and legalLastName would filter out html
-
AddressPage.js -- addressStreet, addressCity, and addressState would filter html
-
DisplayNamePage.js
-
AddDebitCardPage.js
-
IdentityForm.js
-
CloseAccountPage.js -- This input rule for "mesage" is ANYTHING so html is fine
Problem
As noted in this GH: #12268 , we were allowing users to submit workspace names with html tags. However, for most of these string form fields, we strip the html/xml tags in our WAF input rules. So even though we allow users to submit strings with tags in them, we filter them out without letting the user know and try to save the stripped-string on the php side.
cc @flodnv
Two examples I've found:
DisplayNamePage.jsI'm sure there are a lot of others. Lets find them and do the following
Action Preformed
<b> </b>https://recordit.co/TTr47jOQSR
View all open jobs on GitHub
Upwork Automation - Do Not Edit
List of instances
LegalNamePage.js-- legalFirstName and legalLastName would filter out htmlAddressPage.js--addressStreet,addressCity, andaddressStatewould filter htmlDisplayNamePage.jsAddDebitCardPage.jsIdentityForm.jsCloseAccountPage.js-- This input rule for "mesage" is ANYTHING so html is fine