[HOLD for payment 2023-05-09] LHN - Workspace chats for each member appears only going back to online

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #13118

Action Performed:

1. Navgate to staging.new.expensify.com
2. Log in with expensifail account
3. Go offline by navigating to [profile icon] > Preferences > and enable Force offline
4. Create a new workspace.
5. Verify that the #admins, #announce, and workspace chat rooms are created optimistically. Each chat should have a CREATED action.
6. Invite some people to the workspace. Verify that workspace chats for each member appear optimistically.

Expected Result:

Workspace chats for each member appear optimistically while offline

Actual Result:

Workspace chats for each member appears only going back to online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.59.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1767.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01271bd53bc944581d
• Upwork Job ID: 1623086247838068736
• Last Price Increase: 2023-03-15

[stephanieelliott]

Hey @kbecciv I'm not sure if I understand this. Can you clarify what the expected behavior is? I think I am mostly having trouble understanding what "Each chat should have a CREATED action" and " Verify that workspace chats for each member appear optimistically."

Second, I am seeing the same behavior whether I am online or offline, however this issue indicates that the behavior only occurs when offline. Here are the repro steps I am following:

1. Log into staging.new.expensify.com
2. Go offline by navigating to [profile icon] > Preferences > and enable Force offline
3. Create a new workspace. See that #admins and #announce rooms are created for the workspace (they appear in light text/greyed out as compared to other workspaces)
4. Invite a member to the workspace (member is added and all seems as expected)
5. Go online by navigating to [profile icon] > Preferences > and disable Force offline
6. See that workspace #admins and #announce rooms appear "normal" (i.e. they no longer appear in light text/greyed out as compared to other workspaces). Other than that, nothing happens.

[kbecciv]

@stephanieelliott Those two workspace chats appear after back Online

[joekaufmanexpensify]

@kbecciv Just to clarify, when you said:

Issue found when executing PR #13118

In the OP of this issue, you meant that you discovered this bug when doing testing related to the deploy of the PR linked above, correct? Now that you think the PR linked above introduced the bug in this issue? Thanks!

[kbecciv]

Yes, correct.

[MelvinBot]

@stephanieelliott 10 days overdue. I'm getting more depressed than Marvin.

[MelvinBot]

@stephanieelliott 10 days overdue. Is anyone even seeing these? Hello?

[stephanieelliott]

Thanks @kbecciv! Updated the action steps a bit to clarify.