[HOLD for payment 2023-04-03] [$4000] New Lint Rule: onyx-props-must-have default

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Wrap a component with the withOnyx HOC
2. Make the associated prop on the component required in propTypes – do not provide a default.

Expected Result:

The lint rule should catch this and insist than any props originating from withOnyx be optional and provide a default.

Actual Result:

n/a – nothing happens right now

Workaround:

n/a

Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1673645106127709?thread_ts=1673641691.365339&cid=C01GTK53T8Q

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0188c3bb2e4ac48bf8
• Upwork Job ID: 1614039228269498368
• Last Price Increase: 2023-02-03

[melvin-bot]

@roryabraham the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0188c3bb2e4ac48bf8

[melvin-bot]

Triggered auto assignment to @tjferriss (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.