"A room with this name already exists" message appears on Create New Room page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with account that has policyRooms beta enabled
2. Click FAB -> New Room
3. Don't input anything and just click "Create Room" button
4. "A room with this name already exists" message shows below Room Name input field
5. Type any letter on Room Name field and erase all
6. This time, "Please enter a room name" message shows below Room Name input field

Expected Result:

Error message should be consistent as "Please enter a room name"

Actual Result:

"A room with this name already exists" error shows first time

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

**Version Number:**v1.2.48-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

209856169-65c49370-e10c-4b86-9500-af45593cd55d.mov

Recording.1214.mp4

Expensify/Expensify Issue URL:
Issue reported by: @0xmiroslav
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672852094448169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01226a954977211217
• Upwork Job ID: 1610968589634461696
• Last Price Increase: 2023-01-05

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01226a954977211217

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[yuwenmemon]

I can take a look at this one.

[jatinsonijs]

@yuwenmemon I have found root case of this issue during testing. If you want I can post here. I'm asking bcz this issue is Internal and not allowed for external contributors.

[0xmiroslav]

App/src/libs/ValidationUtils.js

Lines 386 to 391 in dee9ac5

	function isExistingRoomName(roomName, reports, policyID) {
	return _.some(
	reports,
	report => report && report.policyID === policyID
	&& report.reportName === roomName,
	);

undefined === undefined is the root cause.
I think we should add some more filters like this:

     return _.some( 
         reports, 
-        report => report && report.policyID === policyID 
-        && report.reportName === roomName,
+        report => report && !_.isEmpty(report.policyID) && report.policyID === policyID 
+        && !_.isEmpty(report.reportName) && report.reportName === roomName, 
     );