[$1000] bottom border line is missing for the logged-in user in Manage members

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. navigate to settings > workspaces
2. press new workspace. it will create a new workspace
3. go to Manage members > check Logged-in user in list

Expected Result:

bottom border should visible under Logged-in user

Actual Result:

bottom border is not visible under Logged-in user

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• iOS / native

Version Number: 1.2.43-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

HSSI1594.MP4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671897956983559

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b06179dc7a0779d9
• Upwork Job ID: 1608008807755079680
• Last Price Increase: 2022-12-28

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b06179dc7a0779d9

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @tgolen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[daraksha-dk]

Proposal

Root cause: wrong logic is being used here when passing border bottom styles
Solution: use _.isEmpty(item.errors) instead of !item.errors here

App/src/pages/workspace/WorkspaceMembersPage.js

Line 260 in f2a01fd

style={[styles.peopleRow, !item.errors && styles.peopleRowBorderBottom, !canBeRemoved && styles.cursorDisabled]}

Demo

border-bottom.mp4