[HOLD for payment 2023-03-31] Display avatars & avatar thumbnails correctly in app

[Beamanator]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Inspect avatar in LHN (in chrome dev tools)

Expected Result:

1. The avatar URL should be the thumbnail avatar, which is the URL ending in _128.

Actual Result:

1. Notice the avatar URL doesn't have _128. at the end, indicating it's not the thumbnail URL

Workaround:

Yes

Platform:

Where is this issue occurring?

• Web
• iOS (probably)
• Android (probably)
• Desktop App
• Mobile Web

Version Number: Latest
Reproducible in staging?: Y
Reproducible in production?: Y
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670258536848779?thread_ts=1669089889.220939&cid=C049HHMV9SM

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Beamanator]

WIP PR is here: #13366

[isabelastisser]

Hey @Beamanator, is this an internal issue? I noticed the Engineering label, and I'm not sure what are my next steps in the process.

[Beamanator]

@isabelastisser yes! I'm working on the fix so I just marked it internal :D

[Beamanator]

Ok problem number one: There's a few places in the server & OldDot that need to be updated to get avatar thumbnail URL no matter what the URL is (now that we're storing different avatar URLs like png, jpg, gif, bmp [update: only should be storing JPEG & PNG soon])

Problem number two: For some reason I only see avatar stored in Onyx, not avatarThumbnail, which comes back from the server and is stored in Onyx here: https://github.com/Expensify/Web-Expensify/blob/da84c28aa29364b043189faf240af69683079be4/lib/UserAPI.php#L2768-L2769

• This happens b/c on sign in we only send avatar for some reason
• Regression from [No QA] Remove unused code in deprecated API #13053, I believe - we used to set the avatar thumbnail in the front end (via formatPersonalDetails) but we deleted that