[HOLD #227234] Receiving Notifications from chats sent months ago

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to a chat with Gabi
2. Start chatting

Expected Result:

Notifications received would be from our chats happening now

Actual Result:

Received notifications from chats received months ago. When I look at those chats they also show “Invalid Date”

Workaround:

unknown

Platform:

Where is this issue occurring?

• Desktop App

Version Number: 1.2.30-0
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669654070339909

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[garrettmknight]

Updated to v1.2.33-7, 'invalid date' persists:

[dylanexpensify]

working on reproducing now

[dylanexpensify]

@garrettmknight is this only with your chat with Gabi?

[garrettmknight]

There's another chat with her that has the 'Invalid Date' text on the same day, but no others.

[garrettmknight]

Happened to @RobertLadue as well:

[marcaaron]

possible theory - something in the API layer changed and is sending an invalid action.created

We render the date here ->

App/src/pages/home/report/ReportActionItemDate.js

Lines 15 to 19 in 820e876

	const ReportActionItemDate = props => (
	<Text style={[styles.chatItemMessageHeaderTimestamp]}>
	{props.datetimeToCalendarTime(props.created)}
	</Text>
	);

So like the UI says it is probably invalid...

Seeing the browser notifications makes sense too since we use the created field to determine whether to show a notification. The created being invalid means the front end interprets it as "new"

App/src/libs/actions/Report.js

Lines 1330 to 1331 in 820e876

	// If we are past the deadline to notify for this comment don't do it
	if (moment.utc(moment(action.created).unix() * 1000).isBefore(moment.utc().subtract(10, 'seconds'))) {

IMO this is in part of a consequence of this issue (needs a better general design) and in part due to some API change that we haven't connected to this bug yet (which seems more urgent to solve).

[dylanexpensify]

Ah very interesting @marcaaron. Should we put this on hold then while we work on the linked issue? Or can we work on this externally in the meantime?

[marcaaron]

I don't think it should be on HOLD, no. It seems like an API change has triggered this and we should make this Internal so someone on the team can prioritize it.