[HOLD for payment 2023-03-06] [$1000] [Feature Request] Workspace - Unable to search for a member to remove them from a workspace.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open NewDot
2. Go to workspace with several members

Expected Result:

There should be a search field to search for a particular member

Actual Result:

No search field

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.22-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

2022-10-31_08-34-02.mp4

Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1667241349993479

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0124bb772c23240b98
• Upwork Job ID: 1623098743086137344
• Last Price Increase: 2023-02-07

[vladamx]

Proposal

The problem:

In WorkspaceMembersPage.js there is a lot of duplicated logic from BaseOptionsList which already supports search and seems like a fit for this kind of lists to be used across the board.

The only difference is that WorkspaceMembersPage supports checkbox ui while BaseOptionsList doesn't.

Solution:

Extend BaseOptionsList to optionally support checkbox UI. As a result we will have a component which we can leverage in many similar list use cases and remove duplicated code.

cc @marcaaron @roryabraham @tgolen

[tgolen]

I'm not totally familiar with all that code, but normally, I am not in favor of adding more functionality to a base class. Ideally, a base class should have very little functionality, and there would be more specific components built on top of it which give the more specific functionality that is needed.

So, I'm not opposed to having a more generic component that is used in many places, but I don't think it should be accomplished by adding more functionality to BaseOptionsList. Can we build like a OptionsListWithCheckboxes component?

[vladamx]

@tgolen I agree with you that composition should be preferred but BaseOptionsList is not that composable to begin with which makes it hard to extend in a flexible manner.

Digging a little bit deeper - BaseOptionsList actually already has the most of the multiple selection logic with props.selectedOptions and props.onSelect so we would just need to parametrise the display from Circle to Checkbox and add Select all checkbox which is trivial

This is how see it atm, by taking a quick glance.

I might try to verify these assumptions by implementing the changes just to see how it would fit.

[melvin-bot]

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

12 days overdue. Walking. Toward. The. Light...