[HOLD][$250] Dev - Getting console warning in android

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. build the app
2. immediately see the errors

Expected Result:

No console warnings displayed

Actual Result:

Console warnings about keyboardAvoidingViewBehavior are present

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.2.12-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665522948008369

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MitchExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aimane-chnaif]

Proposal

App/src/pages/home/ReportScreen.js

Line 210 in 299f07b

keyboardAvoidingViewBehavior={Platform.OS === 'android' ? '' : 'padding'}

The issue happens from above line added here

App/src/components/ScreenWrapper/propTypes.js

Line 24 in 299f07b

keyboardAvoidingViewBehavior: PropTypes.oneOf(['padding', 'height', 'position']),

keyboardAvoidingViewBehavior props value is expected one of these 3 but in android it's set to ''

Solution:

-               keyboardAvoidingViewBehavior={Platform.OS === 'android' ? '' : 'padding'}

remove this line
By doing this, android keyboardAvoidingViewBehavior set to height and iOS keyboardAvoidingViewBehavior keeps padding unchanged.

The default values are found here
ios:

App/src/components/ScreenWrapper/propTypes.js

Line 39 in 6bd5304

keyboardAvoidingViewBehavior: 'padding',

android:

App/src/components/ScreenWrapper/index.android.js

Line 14 in 6bd5304

defaultProps.keyboardAvoidingViewBehavior = 'height';

[hungvu193]

Actually, change the default proptypes can effect other screens.
For this case I think we should change:

App/src/pages/home/ReportScreen.js

Line 210 in 299f07b

keyboardAvoidingViewBehavior={Platform.OS === 'android' ? '' : 'padding'}

into:

-  keyboardAvoidingViewBehavior={Platform.OS === 'android' ? '' : 'padding'} 
+  keyboardAvoidingViewBehavior={Platform.OS === 'android' ? undefined : 'padding'} 

After that, the warning will disappear and also it won't effect other screens.

[thesahindia]

I vote we close this issue as it's not a big problem and will be fixed after #10648

[marcaaron]

Please wait until the issue has been triaged and Help Wanted label added.

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.