Web -Chat - Extra rooms: admin and announce displayed after log in with owner account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when execute PR #10491

Action Performed:

1. Go to staging.new.expensify.com
2. Create 3 accounts:
   applausetester+workspace-admin@applause.expensifail.com/Feya86Katya
   applausetester+workspace-employee@applause.expensifail.com/Feya86Katya
   applausetester+workspace-owner@applause.expensifail.com/Feya86Katya
3. Login with in OldDot with applausetester+workspace-owner@applause.expensifail.com
   and create workspace inviting applausetester+workspace-employee@applause.expensifail.com
   as an employee and applausetester+workspace-admin@applause.expensifail.com as an admin.
4. Log in NewDot with applausetester+workspace-owner@applause.expensifail.com
   account and check 3 policy expense chats, one for each workspace member, and two rooms: #announce and #admin

Expected Result:

3 policy expense chats, one for each workspace member, and two rooms: #announce and #admin are displayed with owner account

Actual Result:

Extra rooms: admin and announce displayed after log in with owner account

Workaround:

Uknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.6.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

@aldo-expensify maybe it's related to #10491?

[roryabraham]

I'm confused by this / not able to reproduce it:

Login with in OldDot with applausetester+workspace-owner@applause.expensifail.com
and create workspace inviting applausetester+workspace-employee@applause.expensifail.com
as an employee and applausetester+workspace-admin@applause.expensifail.com as an admin.

How is it possible to add people to a workspace from OldDot, since clicking on the workspace brings you to NewDot? From NewDot, it's not yet possible to invite people to a workspace with a specific role (admin vs employee). So I'm confused exactly what was done here to create the state we see in the screenshot above.

I did the following:

1. Created three accounts, workspace-owner, workspace-admin, workspace-employee
2. Signed into OldDot as workspace-owner
3. Created a Free Plan (aka Workspace). This took me to NewDot and signed me in.
4. Invited workspace-admin and workspace-employee to the policy from NewDot.

Almost? Everything seems correct now:

workspace-owner

workspace-admin

• Missing #admins room because they are not an admin and cannot be made an admin.
  • Unless I'm mistaken, this is not a bug but just a missing feature
• Missing workspace chat 🐛

workspace-employee

Same state as workspace-admin

[roryabraham]

In any event, workspace chats are still behind a beta, so we don't need to block deploy on this

[roryabraham]

cc @trjExpensify @JmillsExpensify Can you buddy-check my above analysis of this issue please?

[JmillsExpensify]

Agree we don't need to block a deploy.

[JmillsExpensify]

For the workspace chats, can you check whether they were created (via chat switcher), just potentially don't show proactively in the LHN?

[roryabraham]

can you check whether they were potentially created, just potentially don't show proactively in the LHN?

Yes. I checked and they were not discoverable via search or request money pages

[roryabraham]

However, when I sent a message in the workspace chat (as the workspace-owner), then the workspace chat showed up for employee and admin

[roryabraham]

Some more details over here: #10491 (comment)

[aldo-expensify]

Thanks for testing @roryabraham

I understand that the workspace-employee (same as workspace-admin at the moment) should only see their policy expense chat, but I think this hides away if it is empty and archived. I'll test again putting messages on each chat/room before closing the workspace. What I think is a bug is that the #announce room should have disappeared for all non-admin/non-owner