If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
What performance issue do we need to solve?
Better caching for iOS images
What is the impact of this on end-users?
Previously seen avatars/assets will show up faster with suggested change.
List any benchmarks that show the severity of the issue
Proposed solution (if any)
Use FastImage for Avatars and images that are par of the messages.
Avatar.js uses Image from react-native
react-native-render-html - that as far as I know is used for rendering attachment (among the other things) uses Image from 'react-native' if the change with avatars will give us good results it's worth to test patching that library as well. So that it uses fast-image.
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)
Platform:
Where is this issue occurring?
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Upwork URL: https://www.upwork.com/jobs/~013a8690a2c460efd2
View all open jobs on Upwork
Reported by: @parasharrajat originally on this issue.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~019ac837ee43fe141c
- Upwork Job ID: 1620162574495588352
- Last Price Increase: 2023-01-30
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
What performance issue do we need to solve?
Better caching for iOS images
What is the impact of this on end-users?
Previously seen avatars/assets will show up faster with suggested change.
List any benchmarks that show the severity of the issue
Proposed solution (if any)
Use FastImage for Avatars and images that are par of the messages.
Avatar.jsuses Image from react-nativereact-native-render-html - that as far as I know is used for rendering attachment (among the other things) uses Image from 'react-native' if the change with avatars will give us good results it's worth to test patching that library as well. So that it uses fast-image.
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)
Platform:
Where is this issue occurring?
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Upwork URL: https://www.upwork.com/jobs/~013a8690a2c460efd2
View all open jobs on Upwork
Reported by: @parasharrajat originally on this issue.
Upwork Automation - Do Not Edit