Web - New Group - Aviators icon is missing when create a new group

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any account
3. Click on Fub menu - New Group
   4 Select any 4 - 5 user and click Create

Expected Result:

Aviators icon is not missing when create a new group

Actual Result:

Aviators icon is missing when create a new group

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.89.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1002.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

I'll take this one

[JmillsExpensify]

Depending on how we get on, I'd be fine deploying with this shortcoming and we can address tomorrow. It's largely cosmetic.

[tgolen]

@marcaaron Maybe you can help me out with this... I found the problem, but I don't know the cause.

It looks like the route.match.params that is being passed to ReportScreen is not getting the right reportID. Because of this, the reportActions end up being empty, and that's why the ReportWelcomeText isn't shown. Once you refresh the page, then everything works properly.

The redirect happens here:

App/src/libs/actions/Report.js

Line 618 in 599ca8b

Navigation.navigate(ROUTES.getReportRoute(data.reportID));

but I can't find any recent changes to anything anywhere that are suspect.

[tgolen]

I'm also noticing a double-navigation event happening, which I can't make sense of.

I don't know if that's part of the same problem or not.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[marcaaron]

Which one of those routes is from data.reportID ?