Avoid corrupting media URLs with query strings

[coreh]

The existing logic was naively concatenating ?timestamp=... to the end of media URLs, which resulted in corrupted URLs with two ? whenever the URLs already had a query string.

We now use new URL() and searchParams APIs to parse and update the URL

Summary by Sourcery

Use URL and URLSearchParams APIs to append timestamp query parameters to media URLs instead of naive string concatenation, preventing URL corruption when existing query parameters are present.

Bug Fixes:

• Prevent double '?' in media URLs by correctly handling existing query strings when adding timestamp parameters

Enhancements:

• Replace manual query string concatenation with URL("...").searchParams.set in multiple media-fetching methods

[sourcery-ai]

Reviewer's Guide

Replaces naive query string concatenation for media URLs with URL parsing and the searchParams API to correctly append or update timestamp parameters without corrupting existing queries.

Class diagram for updated media URL handling in BaileysStartupService

classDiagram
    class BaileysStartupService {
        +handleImage(image)
        +handleAudio(audio)
        +handlePicture(picture)
        +handlePictureImage(picture)
    }
    class URL {
        +searchParams: URLSearchParams
        +toString()
    }
    class URLSearchParams {
        +set(name, value)
    }
    BaileysStartupService ..> URL : uses
    URL o-- URLSearchParams : has
    BaileysStartupService ..> URLSearchParams : uses

Loading

File-Level Changes

Change	Details	Files
Use URL and searchParams API to append timestamp query parameter instead of string concatenation	Refactored image URL timestamp handling Refactored audio URL timestamp handling Refactored standalone picture URL timestamp handling Refactored nested picture.image URL timestamp handling	src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts

Possibly linked issues

• Problemas ao enviar mídias para o Celular usando o Typebot ou Postman #123: The PR fixes the URL corruption issue by correctly adding timestamps to URLs with query strings, as detailed in the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @coreh - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}