remove lógica de paginação duplicada no fetchChats que causa resultados vazios quando skip > 0

[juniortopanotti]

Problema

O método fetchChats estava aplicando a lógica de paginação duas vezes, causando resultados vazios ao usar o parâmetro skip com valores maiores que 0.

Causa Raiz

1. A query SQL já aplica LIMIT e OFFSET corretamente
2. O código JavaScript então aplica .slice(skip, skip + take) nos resultados já paginados
3. Este "offset duplo" faz com que o slice tente acessar posições do array que não existem

Exemplo do bug

Requisição: {"take": 10, "skip": 10}

1. SQL: LIMIT 10 OFFSET 10 → retorna chats 11-20 (10 itens)
2. JS: .slice(10, 20) → tenta pegar posições 10-20 de um array com apenas 10 itens
3. Resultado: [] (array vazio)

Testes

• ✅ {"take": 10, "skip": 0} - Retorna os primeiros 10 chats
• ✅ {"take": 10, "skip": 10} - Retorna chats 11-20 (anteriormente retornava [])
• ✅ {"take": 5, "skip": 15} - Retorna chats 16-20 (anteriormente retornava [])

Impacto

• ✅ Corrige a funcionalidade de paginação para todos os valores de skip > 0
• ✅ Mantém compatibilidade com versões anteriores
• ✅ Sem mudanças que quebrem implementações existentes

Summary by Sourcery

Remove duplicated pagination logic in fetchChats by deleting the JavaScript slice, relying solely on SQL LIMIT and OFFSET to fix empty results with skip offsets

Bug Fixes:

• Fix empty results when skip parameter is greater than 0 due to double pagination

Enhancements:

• Remove redundant client-side pagination slicing in fetchChats method

Tests:

• Validate fetchChats returns correct chat ranges for various skip and take values

[sourcery-ai]

Reviewer's Guide

Removed redundant JavaScript pagination in fetchChats by relying solely on SQL’s LIMIT/OFFSET and eliminating the extra slice logic

File-Level Changes

Change	Details	Files
Removed redundant JavaScript pagination in fetchChats	Deleted conditional block checking for query.take and query.skip Removed skip and take variable assignments Removed mappedResults.slice(skip, skip + take) invocation	src/api/services/channel.service.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @juniortopanotti - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[foqc]

@juniortopanotti This issue is already being addressed in the following pull request: #1696