Remove refs to Smelss rules#362
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes UI and logic references to the ErikEJ.DacFX.TSQLSmellSCA (“Smells”) rules package so the VSIX/SSMS extensions only surface/install ErikEJ.DacFX.SqlServer.Rules as the community analyzer option.
Changes:
- Updated Manage Rules dialogs (VSIX + SSMS) to remove mentions of
ErikEJ.DacFX.TSQLSmellSCAfrom checkbox text/tooltips and warnings. - Removed “Smells.*” help-link generation and example output references.
- Updated rules-package detection/installation logic to only consider
ErikEJ.DacFX.SqlServer.Rules.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Vsix/Dialogs/ManageRulesDialog.xaml | Removes TSQLSmellSCA from install UI text/tooltip and warning messaging. |
| src/SsmsVsix/Linter/Linting/AnalyzerUtilities.cs | Removes outdated “Smells.*” example comment line. |
| src/SsmsVsix/Dialogs/ManageRulesDialog.xaml | Removes TSQLSmellSCA from install UI text and warning messaging. |
| src/Shared/ViewModels/RuleViewModel.cs | Drops help-link mapping for Smells.* rule IDs. |
| src/Shared/Extensions/ProjectExtension.cs | Stops detecting/installing ErikEJ.DacFX.TSQLSmellSCA; only handles ErikEJ.DacFX.SqlServer.Rules. |
Comment on lines
14
to
16
| private const string SqlServerRulesPackageId = "ErikEJ.DacFX.SqlServer.Rules"; | ||
| private const string TSqlSmellRulesPackageId = "ErikEJ.DacFX.TSQLSmellSCA"; | ||
| private const string Indent = "\n "; | ||
| private const string EndElementIndent = "\n "; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.