Fixed hierarchical checker display #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old algorithm failed to add bugpaths in the following case:
Checker display set to hierarchical.
unix
- unix.MallocSizeof
- unix.Malloc <- ArrayIndexOutOfBounds exception when clicked.
unix.MallocSizeof starts with unix.Malloc and was tried to be added
as a child of unix.Malloc. This resulted the aforementioned exception.
The modified algorithm adds the bugpaths correctly and should work with deeper
checker trees also.
d3b9840 to
9b5c1a5
Compare
gamesh411
requested changes
Sep 18, 2019
| String[] splitted = s.split("\\."); | ||
| if (splitted.length > parentLevel - 1 && splitted[parentLevel - 1].equals(parent) | ||
| && !s.equals(parent)) { | ||
| tops.add(parent + "." + s.split("\\.")[parentLevel]); |
Collaborator
There was a problem hiding this comment.
instead of s.plit("\\.") in this line, splitted array could be used
| if (s.startsWith(parent) && !s.equals(parent)) { | ||
| tops.add(parent + "." + s.split("\\.")[parentDots]); | ||
| String[] splitted = s.split("\\."); | ||
| if (splitted.length > parentLevel - 1 && splitted[parentLevel - 1].equals(parent) |
Collaborator
There was a problem hiding this comment.
wouldn't the following condition be equivalent for our entries in the checkerlist?
if (splitted.length > parentLevel && splitted[parentLevel - 1].equals(parent)) { ... }
Maybe not, just asking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old algorithm failed to add bugpaths in the following case:
Checker display set to hierarchical.
unix
- unix.MallocSizeof
- unix.Malloc <- ArrayIndexOutOfBounds exception when clicked.
unix.MallocSizeof starts with unix.Malloc and was tried to be added
as a child of unix.Malloc. This resulted the aforementioned exception.
The modified algorithm adds the bugpaths correctly and should work with deeper
checker trees also.