Value does not work with bincode serialization as of v0.17#96
Closed
shesek wants to merge 1 commit intoElementsProject:masterfrom
Closed
Value does not work with bincode serialization as of v0.17#96shesek wants to merge 1 commit intoElementsProject:masterfrom
Value does not work with bincode serialization as of v0.17#96shesek wants to merge 1 commit intoElementsProject:masterfrom
Conversation
shesek
added a commit
to Blockstream/electrs
that referenced
this pull request
Oct 9, 2021
A regression introduced in v0.17.0 made `Value` incompatible with bincode: ElementsProject/rust-elements#96 This also requires downgrading rust-bitcoin to v0.26, to match the version used by rust-elements. This reverts commit df99d5e.
a80bd65 to
963facd
Compare
Contributor
|
I suspect this as the culprit: It seems that something is broken about the |
Contributor
|
Oh, no I might have to come back from that. This is about the explicit case, not the confidential one. Strange. Let me look at that instead. |
Merged
Contributor
|
Included in #98. |
SatoKentaNayoro
pushed a commit
to boolnetwork/mempool-electrs
that referenced
this pull request
Nov 29, 2024
A regression introduced in v0.17.0 made `Value` incompatible with bincode: ElementsProject/rust-elements#96 This also requires downgrading rust-bitcoin to v0.26, to match the version used by rust-elements. This reverts commit 2759c50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SerializingDeserializing with big endian fails withIo(Kind(UnexpectedEof)), while little endian fails withCustom("wrong or missing prefix").The PR just adds a failing test case, not a fix. This used to work with rust-elements v0.16.