Conversation
On GitHub where we build the zipfile, it exists, so we don't check out the submodule. If you do, your zipfile won't match! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…ic PR merged. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Build: release builds with tools/build-release.sh are deterministic again.
778657e to
45397b4
Compare
|
Since we build with To prevent the Docker image publishing issue again which we encountered with CLN v25.09 (resolved in #8531 by installing the released crate directly), we must ensure that installing |
|
So, tag the commit and add it to Cargo.toml: ? |
I also tried that with the other library ( |
|
But why?, |
|
Running |
Agree, |
|
Hmpf, this has to be some differently configured git i think. |
|
I created a local branch repro-utoipa-git-tree to reproduce/test this issue. It contains only the @rustyrussell Could you please tag this commit in your fork? I attempted to do it myself but received a 403: forbidden error. I can test again once the tag is available. |
|
Closing this PR in favour of #8547. The change to use our own tree is also failing in Docker building. |
This reverts [commit](ElementsProject@cd1ec72), as an alternative fix has already been introduced in PR [ElementsProject#8547](ElementsProject#8547) to restore reproducible builds. This reversion is necessary because otherwise Docker image building will fail with GitHub Actions or via build-release.sh. The issue arises from Cargo’s inability to resolve the git URL dependencies for clnrest’s utoipa and utoipa-swagger-ui packages within these build contexts. While direct `docker buildx` commands succeeds, Github Action or build-release.sh modifies the build context in a way that prevents Cargo from locating the specific git commit for these dependencies. References: ElementsProject#8530 (comment) https://github.com/ElementsProject/lightning/actions/runs/17435823432 Added fixed SOURCE_DATE_EPOCH flag for reproducible ubuntu builds [8547](ElementsProject#8547) Changelog-None.
This reverts [commit](ElementsProject@cd1ec72), as an alternative fix has already been introduced in PR [ElementsProject#8547](ElementsProject#8547) to restore reproducible builds. This reversion is necessary because otherwise Docker image building will fail with GitHub Actions or via build-release.sh. The issue arises from Cargo’s inability to resolve the git URL dependencies for clnrest’s utoipa and utoipa-swagger-ui packages within these build contexts. While direct `docker buildx` commands succeeds, Github Action or build-release.sh modifies the build context in a way that prevents Cargo from locating the specific git commit for these dependencies. References: ElementsProject#8530 (comment) https://github.com/ElementsProject/lightning/actions/runs/17435823432 Added fixed SOURCE_DATE_EPOCH flag for reproducible ubuntu builds [8547](ElementsProject#8547) Changelog-None.
This reverts [commit](cd1ec72), as an alternative fix has already been introduced in PR [#8547](#8547) to restore reproducible builds. This reversion is necessary because otherwise Docker image building will fail with GitHub Actions or via build-release.sh. The issue arises from Cargo’s inability to resolve the git URL dependencies for clnrest’s utoipa and utoipa-swagger-ui packages within these build contexts. While direct `docker buildx` commands succeeds, Github Action or build-release.sh modifies the build context in a way that prevents Cargo from locating the specific git commit for these dependencies. References: #8530 (comment) https://github.com/ElementsProject/lightning/actions/runs/17435823432 Added fixed SOURCE_DATE_EPOCH flag for reproducible ubuntu builds [8547](#8547) Changelog-None.
This fixes two issues: