Reallow no gossip queries#7174
Merged
cdecker merged 2 commits intoElementsProject:masterfrom Mar 31, 2024
Merged
Conversation
LDK doesn't set this feature if they don't have any useful gossip (mobile nodes) and it was agreed at the spec meeting that we should repurpose this feature to mean "I don't have any useful gossip". Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We now *never* consider asking them anything, even if they are capable (e.g. enabling full gossip stream). This aligns with the latest spec proposal, where lack of `gossip_queries` means "we don't have anything useful to say". Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
vincenzopalazzo
approved these changes
Mar 26, 2024
Collaborator
vincenzopalazzo
left a comment
There was a problem hiding this comment.
ACK 06e850c
Would be good to keep the ldk use case in mind when we design the gossip 2.0
Contributor
|
Is there still a point release planned for this? Breaks our LDK integration with the recent CLN release, which we need to attempt to fix CLN scaling issues we're seeing. |
Collaborator
|
cc @cdecker for the point release info |
Member
|
Sorry about the delay, building repro builds now and then releasing this later today 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LDK in some configurations gets upset. @bluematt suggested we repurpose this bit slightly to mean "I have no useful gossip". I've updated the BOLT feature deprecation lightning/bolts#1092
I would like a point release to fix this if possible.