Ensure that arm-macos environments have sufficient QT thread stack#1342
Merged
psgreco merged 1 commit intoElementsProject:masterfrom Jul 18, 2024
Merged
Conversation
delta1
approved these changes
Jul 18, 2024
|
Tested ACK 9853992 |
jamesdorfman
added a commit
to jamesdorfman/elements
that referenced
this pull request
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issuing assets via the elements-qt console interface on MacOS arm platforms causes the process to crash. This appears to be because the secondary threads on MacOS default to a 512k stack (per https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Multithreading/CreatingThreads/CreatingThreads.html via https://stackoverflow.com/a/23609290 ) -- this in comparison to linux threads that apparently have 8M of stack.
This change forces the QT-related threads to have an 8M stack.