fix: getnewaddress - don't blind bech32 addresses#1246
Merged
psgreco merged 1 commit intoElementsProject:masterfrom Jul 19, 2023
Merged
fix: getnewaddress - don't blind bech32 addresses#1246psgreco merged 1 commit intoElementsProject:masterfrom
psgreco merged 1 commit intoElementsProject:masterfrom
Conversation
Member
|
059a4a6 looks fine to me. Locally the following tests fail These look like real failures; they happen consistently. |
Member
Author
|
Thanks @apoelstra - fixed |
apoelstra
approved these changes
Jul 19, 2023
Contributor
|
Now I'm a bit concerned that this change will break existing workflows of people by unblinding their addresses on thm. |
Member
|
It may, but I think the old behavior was probably wrong. Not sure how best to handle this. |
Contributor
|
I think the old behavior was at least inconsistent, so I'm fine with a comment added to the release notes and this fix making things consistent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1245 -
getnewaddresswill now return an unblinded bech32 address even when-blindedaddresses=1in config