Skip to content

Conversation

@tamarl08
Copy link
Contributor

@tamarl08 tamarl08 commented Oct 4, 2023

  • fix the concatenation of prediction files from xval folds, which used the keys param incorrectly and unnecessarily. This caused a bug only with more than 9 folds.
  • added a 10-fold scenario to the test of that method
  • fixed the description of human-system confusion matrix to match the matrix axes values.
  • changed the title of human-human confusion matrix to be different than the human-system one, so that the links at the top works correctly.

…0 folds scenario, (3) description and title of confusion matrix in reports
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
rsmtool/utils/cross_validation.py 95.34% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@tamarl08 tamarl08 merged commit 10e33f0 into main Oct 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix-rsmxval-predictions branch October 5, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants