-
Notifications
You must be signed in to change notification settings - Fork 19
Add support for output files when auto-generating configurations #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Users can specify `--output` to write to specific files. - If not specified, configs are printed to screen just like before. - Interactive messages show the name of the output file being written to.
Also, fix a logging bug in `rsmexplain`.
- Use test generators to test all possible combinations instead of individual test functions.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
- Coverage 95.82% 95.80% -0.03%
==========================================
Files 32 32
Lines 4430 4432 +2
==========================================
+ Hits 4245 4246 +1
- Misses 185 186 +1
☔ View full report in Codecov by Sentry. |
tamarl08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
damien2012eng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
As #598 states, changes to the
prompt_toolkitlibrary prevent auto-generated configuration files(both interactive and batch) from being redirected to files.This PR:
--outputor-ooption when generating configuration files.--outputoption.--outputoption totest_cli.py.test_utils.TestSetupRsmCmdParserto add support for--outputoption and to use test generators instead of individual functions.rsmexplainunit test and test data file.To review this
<tool> generate --output <file>or<tool> generate --interactive --output <file>commands with various other options (--subgroups,--quiet, etc.) to check that everything works as expected.Closes #598