Skip to content

Conversation

@tamarl08
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8dbba12) 95.88% compared to head (86f8ad6) 95.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          60       60           
  Lines        9348     9356    +8     
=======================================
+ Hits         8963     8971    +8     
  Misses        385      385           
Files Changed Coverage Δ
rsmtool/utils/constants.py 100.00% <ø> (ø)
rsmtool/reporter.py 92.94% <100.00%> (+0.05%) ⬆️
rsmtool/rsmcompare.py 94.93% <100.00%> (+0.13%) ⬆️
rsmtool/rsmpredict.py 99.15% <100.00%> (+0.01%) ⬆️
rsmtool/rsmsummarize.py 97.80% <100.00%> (+0.04%) ⬆️
rsmtool/utils/wandb.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desilinguist
Copy link
Collaborator

@tamarl08 I am assuming you tested actual experiments for all three to confirm that the logging works as expected?

@tamarl08
Copy link
Contributor Author

yes, I ran all tutorials with wandb, see the "rsmxxx-tutorial" projects: https://wandb.ai/etslabs/projects

@desilinguist
Copy link
Collaborator

Hmm, one thing I noticed is that all reports have the name rsmtool_report in W&B. Can we fix that and call them rsmeval_report, rsmcompare_report etc.? Or if that's not possible, let's just call it "HTML report" or something more general?

@tamarl08
Copy link
Contributor Author

@desilinguist good point! I fixed it and reran the tutorials.

@desilinguist desilinguist force-pushed the 597-wandb-pred-comp-sum branch from a1c5ff0 to 86f8ad6 Compare July 25, 2023 22:08
@desilinguist desilinguist merged commit cf9e2a7 into main Jul 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the 597-wandb-pred-comp-sum branch July 26, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants