-
Notifications
You must be signed in to change notification settings - Fork 19
Add wandb logging to rsmtool #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "use_scaled_predictions": false, | ||
| "use_thumbnails": false, | ||
| "use_truncation_thresholds": false | ||
| "use_truncation_thresholds": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 59 59
Lines 9300 9339 +39
=======================================
+ Hits 8916 8954 +38
- Misses 384 385 +1
☔ View full report in Codecov by Sentry. |
|
I think we will need to add tests, @tamarl08. That's not a minor change in coverage. |
|
Thanks for the review @desilinguist @mulhod! I addressed all your comments, leaving the dependency as it is for now. |
|
Okay, just tested this. Couple of things that we should add to the documentation:
Both of these can go under an "Important" note in the |
desilinguist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!! 🎉
Add option to log to W&B from rsmtool.py.
Note: I didn't add this to unit tests since it only allows a very shallow testing. Instead I added a tutorial config that logs to wandb and verified that everything works.
See the results of the most recent run here or try it yourself!