Skip to content

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented Dec 5, 2022

Closes #570.

Convert the ID column to string when reading in the training data file in rsmxval so that it matches the rest of the rsmtool pipeline. Also, add a new test for this use case.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 95.75% // Head: 95.75% // No change to project coverage 👍

Coverage data is based on head (b33347a) compared to base (a77d3f2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files          29       29           
  Lines        4000     4000           
=======================================
  Hits         3830     3830           
  Misses        170      170           
Impacted Files Coverage Δ
rsmtool/utils/cross_validation.py 95.34% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@desilinguist desilinguist merged commit 979958d into main Dec 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the 570-fix-bug-for-integer-ids branch December 6, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in rsmxval with id column composed of integers

4 participants