simulator: Reload Lua widgets also with when "Reload Lua scripts" command issued

[jurgelenas]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Simulator

Current Behavior

simuLuaReloadPermanentScripts() reloads only the the tools and I think telemetry scripts.

We could do something like like this:

 void simuLuaReloadWidgets()
 {
 #if defined(LUA) && defined(COLORLCD)
   luaUnregisterWidgets();
   luaClose(&lsWidgets);
   luaInitThemesAndWidgets();
   LayoutFactory::deleteCustomScreens();
   LayoutFactory::loadCustomScreens();
 #endif
 }

And call it in:

 void simuLuaReloadPermanentScripts()
 {
 #if defined(LUA)
   simuLuaReloadWidgets();
   luaState = INTERPRETER_RELOAD_PERMANENT_SCRIPTS;
 #endif
 }

Or introduce another wasm method simuLuaReloadWidgets().

This is targeting mainly #7164.

Expected Behavior

"Reload lua scripts" command reloads widgets in simulator too.

Steps To Reproduce

Version

Nightly (Please give date/commit below)

Transmitter

RadioMaster TX16S MK3

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

[3djc]

Since widgets are loaded right on radio start, I guess simu must be restarted

[jurgelenas]

Since widgets are loaded right on radio start, I guess simu must be restarted

But it does not have to be this way :)

[pfeerick]

Oh, nice... a suggestion and suggested pattern to implement it... can we keep you @jurgelenas ? 😆

[raphaelcoeffic]

Short answer: not thread-safe at all.

Every function in that sequence touches unprotected global state that the main firmware loop also reads/writes concurrently.

Ideally, this would be implemented just like simuLuaReloadPermanentScripts with a flag.