Merged
Conversation
ghost
approved these changes
Mar 1, 2025
Member
|
Looks ok, but the one issue I have, is that you used the same flag enum for all three proposed fields. |
Member
Author
|
Oooh I thought it's the same because they had the same field name. Converting PRs to draft so I can address that later... |
The return values are not used by our code so this was actually harmless. Return for ExPatch fixed to return a valid string_view. Return type for ToFile changed to bool as string_view made no sense here in signalling an error. Reported by clang on macOS.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.