Refer to Client :id as :key in docs/public APIs for consistency.#18
Merged
Conversation
e207974 to
8967b05
Compare
masha256
reviewed
Mar 25, 2017
| spec.add_development_dependency "rspec", "~> 3.0" | ||
| spec.add_development_dependency "webmock", "~> 1.22" | ||
|
|
||
| spec.add_dependency "public_suffix", "~> 1.4.6" |
There was a problem hiding this comment.
Any chance you guys could use the recent version of public_suffix, anything >= 2.x? A number of popular gems (such as webmock) have a dependency tree that requires public_suffix >= 2.x and this makes using dwolla_v2 >= 1.2 not compatible.
Contributor
Author
There was a problem hiding this comment.
Hey @machadolab,
We originally added this because 1.x is required to support Ruby < 2, but weren't aware of the issues it causes with other gems. I just opened a branch that removes the specific version requirement from the gemspec along with a couple other small changes (see the changelog at the bottom of the README).
You can try it out by updating your Gemfile:
gem 'dwolla_v2', github: 'dwolla/dwolla-v2-ruby', branch: '2.0-dev'Thanks for the heads up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.