Add ODIC Back-Channel Logout#304
Merged
Merged
Conversation
Member
|
Uh, whoops. Literally just heavily modified the session system for MFA. I'll take a look and see what works for both OIDC and MFA. |
Contributor
Author
|
This is ready to be reviewed now |
DecDuck
reviewed
Jan 10, 2026
Member
DecDuck
left a comment
There was a problem hiding this comment.
Just some nitpick stuff, will have more of a look over when I have a wider screen (I'm on mobile).
Contributor
Author
|
Fixed |
04d4817 to
b40eee2
Compare
Member
|
Typecheck is very unhappy |
Contributor
Author
|
Fixed |
DecDuck
requested changes
Jan 14, 2026
Member
|
Just reviewed. Also, does this need a test with the new MFA stuff? |
Contributor
Author
|
Yea, I don't have the setup to properly test the changes rn |
DecDuck
approved these changes
Jan 19, 2026
Huskydog9988
added a commit
to Huskydog9988/drop
that referenced
this pull request
Apr 16, 2026
* prevent returning expired sessions * add issuer to ODIC creds * get id token in ODIC * make session signin return session * working backchannel logout? * require https for ODIC provider * handle wellknown not being https * find session api progress * fix windows build * return session token on session * switch OIDC to #searchSessions * update pnpm * switch to using message on error obj * move odic callback * fix type errors * redirect old oidc callback * make redirect url a URL * remove scheduled task downloadCleanup * fix session search for oidc * fix signin result * cleanup code * ignore data dir * fix lint error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let an ODIC provider sign out users. Also attempted to make the server more spec compliant by verifying responses and enforcing HTTPS for providers by default.