Skip to content

Non-Unicode game titles break admin library page #192

@FurbyOnSteroids

Description

@FurbyOnSteroids

If you add a source with a folder that contains folders with non-unicode characters, the library view will break with the exception:

[request error] [unhandled] [GET] http://localhost:8991/api/v1/admin/library
drop-1      |  InvalidCharacterError: Invalid character
drop-1      |     at btoa (node:buffer:1288:11)
drop-1      |     ... 6 lines matching cause stack trace ...
drop-1      |     at async Server.<anonymous> (file:///app/app/server/chunks/nitro/nitro.mjs:1:97992) {
drop-1      |   cause: DOMException [InvalidCharacterError]: Invalid character
drop-1      |       at btoa (node:buffer:1288:11)
drop-1      |       at createGameImportTaskId (file:///app/app/server/chunks/nitro/nitro.mjs:1:333348)
drop-1      |       at file:///app/app/server/chunks/nitro/nitro.mjs:1:334104
drop-1      |       at Array.filter (<anonymous>)
drop-1      |       at Object.fetchUnimportedGames (file:///app/app/server/chunks/nitro/nitro.mjs:1:334038)
drop-1      |       at async Object.handler (file:///app/app/server/chunks/routes/api/v1/admin/index.get4.mjs:1:1082)
drop-1      |       at async Object.handler (file:///app/app/server/chunks/nitro/nitro.mjs:1:95012)
drop-1      |       at async Server.<anonymous> (file:///app/app/server/chunks/nitro/nitro.mjs:1:97992),
drop-1      |   statusCode: 500,
drop-1      |   fatal: false,
drop-1      |   unhandled: true,
drop-1      |   statusMessage: undefined,
drop-1      |   data: undefined
drop-1      | }

How to reproduce:

  • create folder structure "testfolder/こんにちは、世界/"
  • add "testfolder" as a source within drop
  • go to the admin dashboard and click "library"

I already got a working fix for this. As soon as I figure out how I do pull requests, I'll provide it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions