feat(registry): add AWS ECR registry support with proper validation#2660
feat(registry): add AWS ECR registry support with proper validation#2660EphraimHaber wants to merge 0 commit intoDokploy:canaryfrom
Conversation
Important NoteAWS CLI Required: The server running Dokploy needs AWS CLI installed for ECR authentication |
23cba21 to
0138a7c
Compare
|
just rebsed and orginized the commit |
|
Cool, I'll fix these issues. Hopefully I'll have time for it tomorrow night. |
|
fixed the issues. awaiting CR @Siumauricio |
|
Any update? |
|
Upvoting for this to be reviewed and merged. Would be really helpful and make our deployment processes straightforward |
|
Would really appreciate if this PR could be a bit more prioritized. This has been open for more than 6 months and fixes a key pain point while using dokploy on AWS. Please request you to take a look at this @Siumauricio (sorry for tagging, but just wanted a bit of attention on this PR) |
|
Hi, Sorry for the late reply, can you please create a dedicated branch as we describe in the https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request, also can you fix the conflicts? |
|
Sure, hopefully I'll have time to work on it later today. |
|
@Siumauricio had some nice ui/ux changes in mind, went ahead and made a dedicated branch with screenshots included. #4141 |
Backend changes:
Frontend changes:
This enables users to connect to AWS ECR repositories using their AWS credentials while maintaining backward compatibility with existing Docker registries.
What is this PR about?
Please describe in a short paragraph what this PR is about.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #2040
Screenshots (if applicable)