Skip to content

feat(registry): add AWS ECR registry support with proper validation#2660

Closed
EphraimHaber wants to merge 0 commit intoDokploy:canaryfrom
EphraimHaber:canary
Closed

feat(registry): add AWS ECR registry support with proper validation#2660
EphraimHaber wants to merge 0 commit intoDokploy:canaryfrom
EphraimHaber:canary

Conversation

@EphraimHaber
Copy link
Copy Markdown

  • Add AWS ECR as a new registry type alongside existing cloud registries
  • Implement ECR-specific authentication using AWS credentials instead of username/password
  • Add conditional validation schemas that require different fields based on registry type:
    • ECR: registryUrl, awsAccessKeyId, awsSecretAccessKey, awsRegion
    • Regular: username, password
  • Create executeECRLogin helper function for centralized ECR authentication logic
  • Update both frontend and backend validation to use superRefine with field-specific error messages
  • Fix apiCreateRegistry schema to make username/password optional for ECR registries
  • Add proper shell escaping for security in all registry login commands

Backend changes:

  • Update registry database schema to include AWS ECR fields
  • Add getSafeECRLoginCommand and getSafeDockerLoginCommand helper functions
  • Modify apiTestRegistry to handle ECR authentication flow
  • Update registry services to use centralized login command generation

Frontend changes:

  • Add ECR-specific form fields (AWS credentials, region)
  • Implement conditional form validation matching backend logic
  • Update registry creation/testing UI to handle ECR workflow

This enables users to connect to AWS ECR repositories using their AWS credentials while maintaining backward compatibility with existing Docker registries.

What is this PR about?

Please describe in a short paragraph what this PR is about.

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

closes #2040

Screenshots (if applicable)

@EphraimHaber
Copy link
Copy Markdown
Author

Important Note

AWS CLI Required: The server running Dokploy needs AWS CLI installed for ECR authentication

@EphraimHaber
Copy link
Copy Markdown
Author

just rebsed and orginized the commit

@EphraimHaber
Copy link
Copy Markdown
Author

Cool, I'll fix these issues. Hopefully I'll have time for it tomorrow night.

@EphraimHaber
Copy link
Copy Markdown
Author

fixed the issues. awaiting CR @Siumauricio

@vslowslow
Copy link
Copy Markdown

Any update?

@shivam-clary
Copy link
Copy Markdown

Upvoting for this to be reviewed and merged. Would be really helpful and make our deployment processes straightforward

@shivam-clary
Copy link
Copy Markdown

shivam-clary commented Mar 22, 2026

Would really appreciate if this PR could be a bit more prioritized. This has been open for more than 6 months and fixes a key pain point while using dokploy on AWS. Please request you to take a look at this @Siumauricio (sorry for tagging, but just wanted a bit of attention on this PR)

@Siumauricio
Copy link
Copy Markdown
Contributor

Hi, Sorry for the late reply, can you please create a dedicated branch as we describe in the https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request, also can you fix the conflicts?

@EphraimHaber
Copy link
Copy Markdown
Author

Sure, hopefully I'll have time to work on it later today.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 3, 2026
@EphraimHaber
Copy link
Copy Markdown
Author

@Siumauricio had some nice ui/ux changes in mind, went ahead and made a dedicated branch with screenshots included. #4141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] External Registry - Add AWS ECR as option

4 participants