Merged
Conversation
bethac07
reviewed
Oct 27, 2024
| * **ASSIGN_IP:** Whether or not to assign an a public IPv4 address to each instance in the spot fleet. | ||
| If set to 'False' will overwrite whatever is in the Fleet file. | ||
| If set to 'True' will respect whatever is in the Fleet file. | ||
| Distributed-CellProfiler originally defaulted to assign an IP address to each instance so that one could connect to the instance for troubleshooting but that need has been obviated by the level of logging currently in DCP. |
bethac07
reviewed
Oct 27, 2024
|
|
||
| 1) Optimize `MACHINE_TYPE` and `EBS_VOL_SIZE` based on the actual memory and harddrive needs of your run. | ||
| 2) When possible, mount your S3 bucket using S3FS so that you can set `DOWNLOAD_FILES = 'False'` to not incur file egress costs. | ||
| 3) Set `ASSIGN_IP = 'False'` so that you don't pay for IPv4 addresses per EC2 instance in your spot fleet. |
Collaborator
There was a problem hiding this comment.
Can we add a tiny bit more detail here, approximate charges, what this is for, etc? Fine to just point to other points in the docs
Collaborator
|
A couple of tiiiiiiny notes |
Member
Author
|
@bethac07 better? |
bethac07
approved these changes
Oct 28, 2024
Collaborator
bethac07
left a comment
There was a problem hiding this comment.
Thanks, you're the best!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this issue raised in Distributed-Something. Tested with DCP and once approved here will make similar edits to DS.
Since
ASSIGN_IPcosts money I set it up so that if set toFalsein the config it will overwrite whatever is in the fleet file but if set toTrueit will respect whatever is in the fleet file as I didn't want to introduce a new config variable that would overwrite the Fleet file to add a cost.I also thought it was important for it to overwrite what's in the fleet when set to False in the config because (in our experience) Fleet files are so rarely edited that they're passed around from project to project, person to person within the lab and therefore to actually get the behavior we want now that IP addresses cost money, we need to overwrite the
Truethat's in all the copies of our Fleet files being passed around.