Coinbase: remove order fetch after submission#853
Merged
vslee merged 1 commit intoDigitalRuby:mainfrom Nov 22, 2024
Merged
Conversation
jjxtra
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #818, Coinbase was updated for the V3 API. As part of this, a fetch of the order was added during order submission. Since Coinbase does not return full order info as a response. Checking to fill in the additional information made sense, but also causes some problems. It results in 2 round trips to the server for each order submission. This can be problematic if many orders are being submitted quickly. There is no way for a user to opt out of this behavior (without complicating the method signature).
Thus, I will remove the order fetch and allow users who need the additional info to fetch it with an additional call. This also frees us of the dilemma of what to do if the new order does not match the submitted specs. Such as a buy order turning into sell order, as happens in the sandbox.