Skip to content

fix binance ticker websocket with symbol #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vslee merged 1 commit into from
Jan 11, 2023
Merged

fix binance ticker websocket with symbol #794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/ExchangeSharp/API/Exchanges/BinanceGroup/BinanceGroupCommon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,11 +269,21 @@ protected override async Task<IWebSocket> OnGetTickersWebSocketAsync(Action<IRea
JToken token = JToken.Parse(msg.ToStringFromUTF8());
List<KeyValuePair<string, ExchangeTicker>> tickerList = new List<KeyValuePair<string, ExchangeTicker>>();
ExchangeTicker ticker;
foreach (JToken childToken in token["data"])

// if it is the tickers stream, data will be an array, else it is an direct item.
var data = token["data"];
if (data is JArray)
foreach (JToken childToken in data)
{
ticker = await ParseTickerWebSocketAsync(childToken);
tickerList.Add(new KeyValuePair<string, ExchangeTicker>(ticker.MarketSymbol, ticker));
}
else
{
ticker = await ParseTickerWebSocketAsync(childToken);
ticker = await ParseTickerWebSocketAsync(data);
tickerList.Add(new KeyValuePair<string, ExchangeTicker>(ticker.MarketSymbol, ticker));
}

if (tickerList.Count != 0)
{
callback(tickerList);
Expand Down